[4.5] Impossible to set the Directional Soft Shadow Filter Quality to Ultra on D3D12 (solved in 4.6)

[DemonBunnyBon]

Tested versions

• Reproducible in 4.5.1.stable

System information

Godot v4.5.1.stable (f62fdbd) - Windows 11 (build 26200) - Multi-window, 1 monitor - Direct3D 12 (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; 32.0.15.8157) - Intel(R) Core(TM) i5-10400F CPU @ 2.90GHz (12 threads) - 23.92 GiB memory

Issue description

As the title states, trying to use Ultra Soft Shadow Filter Quality on Directional Shadows is impossible with D3D12 on Windows. Attempting to do so with either the project settings or at runtime through GDScript results in the following error:

patch_specialization_constant: Condition "int_value & (1 << 31)" is true. Returning: 0
 <C++ Source>  drivers/d3d12/rendering_shader_container_d3d12.cpp:106 @ patch_specialization_constant()

Steps to reproduce

• Set rendering/rendering_device/driver.windows to d3d12 in Project Settings.
• Restart editor for the setting to apply.
• Set rendering/lights_and_shadows/directional_shadow/soft_shadow_filter_quality to Soft Ultra in Project Settings or use RenderingServer.directional_soft_shadow_filter_set_quality(RenderingServer.SHADOW_QUALITY_SOFT_ULTRA) at runtime.

Minimal reproduction project (MRP)

N/A

[akien-mga]

CC @blueskythlikesclouds

I haven't tested if the issue is reproducible (I'm on Linux so testing D3D12 is trickier), but note that a lot of bugs have been fixed for D3D12 in Godot 4.6-dev, so it might be worth testing 4.6-dev5 to see if this is still reproducible. (I don't a priori whether this specific issue was addressed though.)

[AThousandShips]

I can't seem to reproduce on 4.6.dev [78d9194], seems potentially already solved

D3D12 12_0 - Forward+ - Using Device #0: AMD - AMD Radeon 780M Graphics

[AThousandShips]

Confirmed that this occurs for me in 4.5.1 but not in latest, so resolved

Closing but would be good to pin down what solved it and see if it needs cherry-picking

[blueskythlikesclouds]

These two PRs fixed it:
#111356
#111762

[AThousandShips]

Would be good to see if there's a way to cherry-pick the specific fix, reopening as a 4.5 specific issue so we can track that