Mod loading broken on Android (ProjectSettings.load_resource_pack)

[mrimvo]

Godot version

3.4 stable

System information

Ubuntu 18.04

Issue description

I'm working on an Android Game, which supports loading user-made mods.

ProjectSettings.load_resource_pack( some_mod_zip, false )

This line would replace the contents of res:// instead of just adding the mod contents.

Steps to reproduce

1. Download the example project
2. load it in Godot Editor
3. Run it on Android.

Minimal reproduction project

Mod-Loading-Android.zip

Main.gd from the example project:

extends Node


# This works on all platforms, EXCEPT
# - on Android
# - in the Godot Editor

func _ready():
	$TextEdit.text = "Original Files\n"
	$TextEdit.text += str(list("res://")) + "\n"
	ProjectSettings.load_resource_pack("res://Mod.zip", false)
	$TextEdit.text += "After Mod-Loading (expected: original files + Mod.gdc)" + "\n"
	$TextEdit.text += str(list("res://")) + "\n"


func list(path):
	var pathes = []
	var dir = Directory.new()
	if dir.open(path) == OK:
		dir.list_dir_begin(true)
		while true:
			var file = dir.get_next()
			if not file: break
			pathes.append(file)
	return pathes

The output is something like this:

Original Files
[.import, Main.gd.remap, Main.gdc, Main.tscn, Mod.zip, default_env.tres, icon.png, icon.png.import, project.binary]
After Mod-Loading (expected: original files + Mod.gdc)
[Mod.gdc]

Expected: The original files and the Mod.gdc should be in res://
Observed: the original files disappeared.

[werdnahull]

@akien-mga confirmed that this is still an issue in 3.5.2 Stable and 3.5.2 Stable Mono.

Exporting to:
Samsung Galaxy s10e
Android 12

[werdnahull]

@akien-mga I just tested, and this also affects iOS exports.

[werdnahull]

@akien-mga my apologies, this does NOT affect iOS. I had missed a setting in the Export settings.

That said, is it possible to get eyes on this issue? Who can I talk to to get support for this?

[werdnahull]

@akien-mga this is also still an issue in 4.0.2.stable. Uploading a slightly updated MRP for 4.x:

Mod-Loading-Android.4.test.zip

[Calinou]

@werdnahull Thanks for providing an updated MRP 🙂

That said, please don't ping the maintainer who added labels on every comment, especially if they never commented on the issue itself.

my apologies, this does NOT affect iOS. I had missed a setting in the Export settings.

To clarify, which export option did you change for iOS?

That said, is it possible to get eyes on this issue? Who can I talk to to get support for this?

Android platform-specific issues are unfortunately often difficult to resolve, and only a few contributors are knowledgeable with the platform. This will take a while to be fixed.

[werdnahull]

@Calinou

please don't ping the maintainer who added labels on every comment, especially if they never commented on the issue itself.

Apologies, I am not familiar with the Github etiquette.

To clarify, which export option did you change for iOS?

I was loading packs from the user:// directory, and I had missed the user_data/accessible_from_files_app setting. I think it was simply user error, and not enabling the setting that specifically made ProjectSettings.load_resource_pack work.