[3.x] error: unknown warning group '-Wdeprecated-copy-with-user-provided-copy'

[madmiraal]

Godot version

3.x (28afd32)

System information

Github Workflow: iOS

Issue description

#68077 included trying to silence a number of warnings in the Bullet headers using:

godot/modules/bullet/collision_object_bullet.h

Lines 40 to 43 in 28afd32

	#if defined(__clang__) && (__clang_major__ >= 13)
	#pragma clang diagnostic push
	#pragma clang diagnostic ignored "-Wdeprecated-copy-with-user-provided-copy"
	#endif

However, this change sometimes causes the workflow builds to fail with:

error: unknown warning group '-Wdeprecated-copy-with-user-provided-copy', ignored [-Werror,-Wunknown-warning-option]

See: https://github.com/madmiraal/godot/actions/runs/3451765341/jobs/5761214187

We're using runs-on: "macos-latest", which should use macOS 11. However this is not always true. For example, I notice that when it failed it is running on macOS 11.7.1, but when it succeeded it's running on macOS 12.6.1; so this may be the difference.

Note: the version of clang is different with each version of the OS:

• macOS 11.7 comes with clang 13.0 ¹
• macOS 12.6 comes with clang 14.0 ²

However, clang 13.0 does support -Wdeprecated-copy-with-user-provided-copy³. So, this shouldn't be the issue.

1 https://github.com/actions/runner-images/blob/main/images/macos/macos-11-Readme.md
2 https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md
3 https://releases.llvm.org/13.0.0/tools/clang/docs/DiagnosticsReference.html#wdeprecated-copy-with-user-provided-copy

Steps to reproduce

I pulled the 3.x branch and pushed it to my local fork.

Minimal reproduction project

N/A

[akien-mga]

That's really weird indeed. I checked on godbolt.org and x86_64 clang 13.0.0 does support the flag fine.

Maybe Apple Clang's version which defines __clang_major 13 doesn't define it for some reason?

[bruvzg]

Maybe Apple Clang's version which defines __clang_major 13 doesn't define it for some reason?

Apple clang 14, have __clang_major__ defined and set to 14, so 13 should have it set too.

[bruvzg]

I guess the issue might be Apple clang 13 from XCode 13.2.1 (default for GitHub macOS 11 CI) is based on LLVM 12.0 not 13.0

[bruvzg]

So we should check for clang version 13.1.6+ not just major 13.

[akien-mga]

The best option might be to patch bullet if we can (and PR upstream).

Otherwise here we'll need different checks for LLVM Clang and Apple Clang (though I don't reproduce the warning compiling for Linux with LLVM Clang 15.0.6).