Inspector: Visual shader resource menu collapses when toggling flags

[KMouratidis]

Godot version

4.0.stable

System information

Windows 11, Forward+, Nvidia 3060 (laptop)

Issue description

Don't know how to describe it better than the title. See screen capture:

Steps to reproduce

1. Click on surface material override
2. shader > new shader > create a visual shader
3. Expand flags menu
4. Click on any flag

Minimal reproduction project

ShaderMenuCollapse.zip

[Calinou]

• Related to Can't smoothly change tool script export vars which call functions that do work #75177.

This likely occurs because changing a flag calls notify_property_list_changed(), which causes the inspector to be rebuilt entirely.

[ducklin5]

calling notify_property_list_changed() directly on a custom resource causes sections to fold as well. The effect is quite annoying when editing string properties (if the property is configured to trigger notify_property_list_changed).

Are there any updates/fixes for this yet? If not, I can try make a PR. Where might the code be to prevent folding all the sections?

[ducklin5]

I had some time to find where this logic is:
Object::notify_property_list_changed [ref]
eventually calls EditorInspector::_changed_callback [ref]
which then triggers a tree update on the next editor refresh. [ref]
here is the EditorInspector::update_tree routine which tries to restore the focus on each refresh [ref]

[kitbdev]

• Same as Visual shader inspector panel always collapse on value change #81481
• Fixed by Don't fold resources when child of main inspector exits #95149

Thanks!