Android editor: Update game menu bar to match desktop editor - #119156

@Repiteo note that this is a follow-up to #118664 and their targeted queues are currently crosswired.

@Repiteo note that this is a follow-up to #118664 and their targeted queues are currently crosswired.

@AdriaandeJongh This is only a follow up in design, this PR doesn't depend on that one to be merged first.

Edit: Oh, that one is now queued for 4.8, then I'm fine with moving this to 4.8 as well.

Yeah, this is more a 4.8 change. It'll be part of its first dev cycle though!

Thanks!

@syntaxerror247 There is a bug! or it might be a deliberate change IDK! But the switching between Embedded and PIP mode isn't instant anymore and effects are rather seen on the next run! Also the menu bar doesn't seems to match with the latest highlighted style changes in the desktop version of 4.8 dev1 :P 🫡

@syntaxerror247 There is a bug! or it might be a deliberate change IDK! But the switching between Embedded and PIP mode isn't instant anymore and effects are rather seen on the next run! Also the menu bar doesn't seems to match with the latest highlighted style changes in the desktop version of 4.8 dev1 :P 🫡

That may be a side effect of #121155.

@GDevSh007 Can you specify which version of the editor you're seeing the PiP bug on?

@m4gr3d I used the 4.8 dev1 just for testing and noticed it! but then when I switched back to 4.7.1 stable! I realised the issue exist in that too! So I'm not sure of my memory if instant switching was actually present in the older versions!

@m4gr3d I used the 4.8 dev1 just for testing and noticed it! but then when I switched back to 4.7.1 stable! I realised the issue exist in that too! So I'm not sure of my memory if instant switching was actually present in the older versions!

@GDevSh007 That fix was cherry-picked in 4.7.1 so it makes sense if you see the bug in both 4.8-dev1 and 4.7.1.

Can you create an issue with a recording showing the bug and assign it to @syntaxerror247.
We'll try to get a fix ready for 4.7.2.

That may be a side effect of #121155.

Um... that PR shouldn't affect this because we call updatePiPParams manually when activating PiP (on touch outside)

Anyways, an issue report with recording would help because I don't think we are taking about the same issue here.

@syntaxerror247 I don't think so its a major issue that is worth making a video recording! Yet still I will attach a clip! Beside that PIP mode feels only useful for its button for collapsible menu bar!

@GDevSh007 What you're showing looks like expected behavior; notice there's a toast that shows when you enable / disable embedded mode that describes it'll only take effect in the next run.

I think you were mixing PiP mode vs embedded / full-screen mode; PiP mode is what you are seeing at 0:22.