Skip to content

Conversation

@Akkadius
Copy link
Member

@Akkadius Akkadius commented Jun 10, 2025

Adds support for hex dumping

image

@Akkadius Akkadius force-pushed the akkadius/feat-hex-dumping branch from a6d5793 to cfc2de3 Compare June 10, 2025 19:22
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Akkadius
Copy link
Member Author

image

Added a few more test cases and modifications. Should ready for the most part

@Akkadius Akkadius mentioned this pull request Jun 10, 2025
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it's sufficient for a first version.

Maybe you could add an example of []int8 to make sure it doesn't get rendered as hexdump

Something like []int8{0,33,44,55}

@Akkadius
Copy link
Member Author

I feel like it's sufficient for a first version.

Maybe you could add an example of []int8 to make sure it doesn't get rendered as hexdump

Something like []int8{0,33,44,55}

Can you clarify?

Seems to render fine

image

@ccoVeille
Copy link
Contributor

Then it's fine 👍

@Akkadius
Copy link
Member Author

Then it's fine 👍

Sounds good. Thanks for taking a look!

@Akkadius Akkadius merged commit 49ecb4f into main Jun 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants