chore: remove enableColor and colorize local variables #38
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| } | ||
| val.Recursive.Self = val.Recursive // cycle | ||
|
|
||
| Dump(val) |
There was a problem hiding this comment.
I'm unsure why this one was there, maybe it something you forgot or wanted to keep, let me know
There was a problem hiding this comment.
It was for manual visual testing, which I'd prefer to keep in
godump.go
Outdated
| } | ||
|
|
||
| // format applies the configured formatter to the string with the given color code. | ||
| func (d *Dumper) format(code, str string) string { |
There was a problem hiding this comment.
"format" is ambiguous and could have many implied meanings - I'd very much prefer to keep this as "colorize"
| } | ||
| return true | ||
| } | ||
|
|
godump.go
Outdated
| // It defaults to [runtime.Caller], it is here to be overridden for testing purposes. | ||
| callerFn func(skip int) (uintptr, string, int, bool) | ||
|
|
||
| formatter Colorizer |
godump.go
Outdated
| // htmlColorize colorizes the string using HTML span tags. | ||
| func htmlColorize(code, str string) string { | ||
| // formatHTML colorizes the string using HTML span tags. | ||
| func formatHTML(code, str string) string { |
godump.go
Outdated
| return str | ||
| } | ||
| // formatANSIColor colorizes the string using ANSI escape codes. | ||
| func formatANSIColor(code, str string) string { |
There was a problem hiding this comment.
This adds Color as a qualifier to "format" as well when it could just be "colorizeANSI"
godump.go
Outdated
|
|
||
| // colorize is the default colorizer function. | ||
| var colorize Colorizer = ansiColorize // default | ||
| func formatNoColor(code, str string) string { |
There was a problem hiding this comment.
colorizeNone or colorizeUnstyled
ccoVeille
force-pushed
the
refactor
branch
2 times, most recently
from
f73a23d to
5d5f9cb
Compare
|
Could you review and merge ? I'm a bit afraid newly opened PR could cause too many conflicts if code keep diverging. Example: |
ccoVeille
force-pushed
the
refactor
branch
2 times, most recently
from
a624abb to
ce8de10
Compare
|
I hope this PR is merged soon, as I’ve also experienced race conditions. Thank you in advance to @ccoVeille and @Akkadius for addressing these issues. |
3 participants
supersedes #23 and #24
Fix #34