feat: support up to Go 1.18 #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, so the code modernization detection break things here... |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ccoVeille
force-pushed
the
go-version
branch
2 times, most recently
from
aba48bb to
4f7700b
Compare
ccoVeille
commented
Jul 25, 2025
ccoVeille
force-pushed
the
go-version
branch
9 times, most recently
from
4d4ddf8 to
aed133b
Compare
ccoVeille
commented
Jul 26, 2025
ccoVeille
commented
Jul 26, 2025
Andrei-hub11
approved these changes
Jul 26, 2025
|
Does your code change about ANSI windows work if you cherry pick temporarily my commit into your branch ? |
|
I cherry-picked your commit but ran into a dependency issue. The cherry-pick worked fine, but when I run go mod tidy, it automatically upgrades from go 1.18 to go 1.23.0 because the dependencies require it: golang.org/x/sys@v0.34.0 requires go@1.23.0
golang.org/x/term@v0.33.0 requires go@1.23.0 |
|
Yes, I was worried about it |
|
@Andrei-hub11 could you tell me if this solves the issue? go mod tidy -go=1.18 |
|
Akkadius
reviewed
Aug 11, 2025
The code can be used with old Go versions. The CI will also run tests for Go 1.18 and latest -rc versions.
Akkadius
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code can be used with old Go versions.
The CI will also run tests for Go 1.18 and latest -rc versions.
Fixed #42