En/http redirects

[Umang01-hash]

Pull Request Template

Description:

• Resolves How to Perform Redirects in Gofr? #1531

Example:

package main

import (
	"gofr.dev/pkg/gofr"

	"gofr.dev/pkg/gofr/http/response"
)

func main() {
	app := gofr.New()

	app.GET("/old-page", func(ctx *gofr.Context) (any, error) {
		// Redirect to a new URL 
		return response.Redirect{URL: "https://example.com/new-page"}, nil
	})

	app.Run()
}

Additional Information:

• Mention any relevant dependencies or external libraries used.
• Include screenshots or code snippets (if necessary) to clarify the changes.

Checklist:

• I have formatted my code using goimport and golangci-lint.
• All new code is covered by unit tests.
• This PR does not decrease the overall code coverage.
• I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

[coolwednesday]

@Umang01-hash , Can we also check and add tests for url with path and query params as well as request Bodies, headers etc.....get handled successfully through the redirect. I feel that is not the case right now.

[coolwednesday]

@Umang01-hash , Can we also check and add tests for url with path and query params as well as request Bodies, headers etc.....get handled successfully through the redirect. I feel that is not the case right now.

@Umang01-hash, Can we add test for these cases ? I feel this implementation can fall short in fitting these usecases.

[ccoVeille]

@Umang01-hash cc @coolwednesday

I got not feedback on these

• En/http redirects #1640 (comment)
• En/http redirects #1640 (comment)
• En/http redirects #1640 (comment)

so I'm moving my comment to "request changes"

[coolwednesday]

This can be removed.

[ccoVeille]

Good catch

[ccoVeille]

Good catch

[ccoVeille]

Nitpicking, there are no need to update this, especially if we consider it diverges from Go standards

Suggested change

	var resp any
	switch v := data.(type) {
	var resp any
	switch v := data.(type) {

[ccoVeille]

🎨 style

Suggested change

	case resTypes.Redirect:
	switch r.method {
	case http.MethodPost, http.MethodPut, http.MethodPatch:
	statusCode = http.StatusSeeOther // 303
	default:
	statusCode = http.StatusFound // 302 by default
	}
	case resTypes.Redirect:
	// HTTP 302 by default
	statusCode = http.StatusFound
	switch r.method {
	case http.MethodPost, http.MethodPut, http.MethodPatch:
	// HTTP 303
	statusCode = http.StatusSeeOther
	}

[ccoVeille]

There is something I cannot explain: why we computed this line 30

         statusCode, errorObj := r.determineResponse(data, err)

And we here don't care about statusCode we computed

Shouldn't we check if data.type is not redirect before calling determineResponse ? And so redirect without calling it