Adding gRPC Client Streaming Example #1695
Open
+1,329
−548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coolwednesday
commented
May 6, 2025
•
coolwednesday
commented
- This PR adds examples for the current gofr-cli approach to additionally also let user generate gRPC streaming handlers with all the observability features, i.e. logs, metrics, traces.
- This PR can only be merged after merging CLI PR : Adding template to generate grpc streaming code gofr-cli#48
- This PR can be tested after merging server side implementation in the following PR : Adding examples and modifying grpc to add interceptor for streaming #1684
ccoVeille
reviewed
May 6, 2025
| @@ -0,0 +1,17 @@ | |||
| # GRPC Client Example | |||
There was a problem hiding this comment.
Suggested change
| # GRPC Client Example | |
| # gRPC Client Example |
| } | ||
|
|
||
| // ServerStreamHandler handles server-side streaming with detailed response tracking | ||
| func (c *ChatHandler) ServerStreamHandler(ctx *gofr.Context) (interface{}, error) { |
There was a problem hiding this comment.
Suggested change
| func (c *ChatHandler) ServerStreamHandler(ctx *gofr.Context) (interface{}, error) { | |
| func (c *ChatHandler) ServerStreamHandler(ctx *gofr.Context) (any, error) { |
| } | ||
|
|
||
| // Return detailed stream information | ||
| return map[string]interface{}{ |
There was a problem hiding this comment.
Suggested change
| return map[string]interface{}{ | |
| return map[string]any{ |
Here and everywhere in fact
| @@ -0,0 +1,17 @@ | |||
| # GRPC Client Example | |||
There was a problem hiding this comment.
Suggested change
| # GRPC Client Example | |
| # gRPC Client Example |
But maybe this, no?
Suggested change
| # GRPC Client Example | |
| # gRPC Unary Client Example |
| //HealthCheck to SayHello Service. | ||
| //res, err := g.helloGRPCClient.Check(ctx, &grpc_health_v1.HealthCheckRequest{Service: "Hello"}) | ||
| //if err != nil { | ||
| // HealthCheck to SayHello Service. |
There was a problem hiding this comment.
I don't see why the example comes with commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.