JDS Components#143
Open
Harshit11Narula wants to merge 1 commit into
Open
Conversation
t007rushi
reviewed
Aug 2, 2023
t007rushi
left a comment
t007rushi
left a comment
Collaborator
There was a problem hiding this comment.
There is no need of self explanotory comments we can remove to reduce lib size
| }, | ||
| methods: { | ||
| getLabelStyle(crumb) { | ||
| // Merge the default labelStyle with crumb-specific styles, if any |
Collaborator
There was a problem hiding this comment.
if comments use is complete can you remove plz
| } | ||
|
|
||
| .image-container.rounded-corner img { | ||
| border-radius: 8px; /* Set your desired border radius */ |
Collaborator
There was a problem hiding this comment.
try to use consistent units as above used 0.5 rem and here 8px
as both same on the calculation
will suggest to use relative units
Comment on lines
+26
to
+38
| .jds-link:hover { | ||
| color: red; /* Change link color on hover */ | ||
| text-decoration: none; /* Remove underline on hover */ | ||
| } | ||
|
|
||
| /* Active styles for the link (when clicked) */ | ||
| .jds-link:active { | ||
| color: green; /* Change link color when clicked */ | ||
| } | ||
|
|
||
| /* Focus styles for the link (when tabbed to) */ | ||
| .jds-link:focus { | ||
| outline: 2px solid purple; /* Add an outline when the link is focused */ |
Collaborator
There was a problem hiding this comment.
no need for comments I think as the selectors are self explanatory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.