Skip to content

fix(net/ghttp): windows web admin restart only shutdowns but doesn't restart #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lonevle wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix(net/ghttp): windows web admin restart only shutdowns but doesn't restart #4809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9154736
fix: windows web admin restart only shutdowns but doesn't restart
lonevle Jul 24, 2026
e548fdf
Merge branch 'master' into fix/windows-restart-bug
hailaz Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion net/ghttp/ghttp_server_admin_process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,9 @@ func restartWebServers(ctx context.Context, signal os.Signal, newExeFilePath str
}
// Controlled by web page.
// It should ensure the response wrote to client and then close all servers gracefully.
// On Windows, we don't close the server here.
// The new process will kill the old one when it starts.
gtimer.SetTimeout(ctx, time.Second, func(ctx context.Context) {
forceCloseWebServers(ctx)
if err := forkRestartProcess(ctx, newExeFilePath); err != nil {
intlog.Errorf(ctx, `%+v`, err)
}
Expand Down
Loading