fix(gdb/mysql): always URL-encode timezone value in DSN to prevent '+' from being interpreted as space (#4759) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #4822
Open
waterWang wants to merge 1 commit into
Conversation
…' from being interpreted as space (gogf#4759)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4759
Problem
When setting a MySQL timezone value containing '+' (e.g.,
'+00:00'), theconfigNodeToSourcefunction only URL-encodes the timezone if it contains '/'. The '+' character is not encoded, causing the Go MySQL driver to interpret it as a space in the query string, resulting in:Fix
Always URL-encode the timezone value with
url.QueryEscapeinstead of only when it contains '/'. This ensures special characters like '+', ':', and quotes are correctly encoded.Verification
url.QueryEscape(UTC)→UTC(no change for safe values)url.QueryEscape(Asia/Shanghai)→Asia%2FShanghai(same as before)url.QueryEscape(+00:00)→%27%2B00%3A00%27(now correctly encoded)stringsimport is no longer needed and has been removed.