Morexxx #594
Open
Morexxx #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows omitting XXX fields when using moretags
… types and either call Compare if they are the same or return 1/-1. (#600)
…5eaa - protoc-gen-go: generate XXX_OneofWrappers instead of XXX_OneofFuncs (#613)
* libprotoc: update to version 3.9.1 * libprotoc: update travis protoc version to 3.9.1
Fixes #617 Adds test which generates a marshalTo for a oneof message. This will fail to compile if the wrong size method is generated in the marshalTo method.
…c90f - Log parsing errors using log pkg
…bf7 - jsonpb: fix marshaling of Duration
…f25b - all: fix reflect.Value.Interface races.
Upstream commits from golang/protobuf
* add test ci-workflow * ci-workflow. update install protobuf script to use HOME var as configure prefix * workflow config update * github/actions. add trigger for pull requests on master
…repeated and non-nullable. (#631) * GoString plugin: generate values instead of pointers when a field is repeated and non-nullable. * Added additional test for repeated, nullable fields. Regenerated pbs.
* tests. added test case for issue (#619). Compare marshaling between a proto.Buffer and proto.Marshal with different proto.Buffer sizes. * proto/buffer. added buffer cap adjustment before giving it to marshal. This allows us to marshal at the correct place when the buffer contains a larger backing buffer. (#619) * proto/buffer. remove unsafe/reflect slice cap adjustment and rather use a full slice expression * proto/buffer. encode. add issue620 tests here * proto/buffer encode. removed unnecessary slicing. (#619) * proto/buffer. err check previously ignored error * issue619. add test package to make regenerate list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase for #486