Support for Swift 6.1's stricter type syntax #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formatting functions were moved to MemberwiseInitFormatter but that commit missed removing them from MemberwiseInitMacro.
This addresses an incompatibility with Swift 6.1 (included in Xcode 16.3 beta) where the macro would fail when used with type parameters. In Swift 6.1, metatype syntax requires the .self suffix when used in this context. Before this fix: - Code like `@InitRaw(type: String?)` would fail with type errors in Swift 6.1 - This was a previously warned deprecation that is now enforced in Swift 6.1 The implementation now: - Correctly handles both Swift 5 style type references (without `.self`) - Supports Swift 6.1 style type references (with `.self` suffix) - Maintains backward compatibility while being future-proof Fixes #47
This works around an (erroneous) compiler build error on swift-issue-reporting. See: pointfreeco/swift-issue-reporting#150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
@Init(type:)and@InitWrapper(type:)on Swift 6.1, and some housekeeping.This primarily addresses an incompatibility with Swift 6.1 (included in Xcode 16.3 beta) where the macro would fail when used with type parameters. In Swift 6.1, metatype syntax requires the .self suffix when used in this context.
Before this fix:
@Init(type: String?)would fail with type errors in Swift 6.1The implementation now:
.self).selfsuffix)Additional housekeeping improvements:
Fixes #47
Note the exact Swift version I tested against: