Add `scanner` cmd by rizul2108 · Pull Request #396 · goharbor/harbor-cli

rizul2108 · 2025-04-12T05:46:56Z

Description

This pull request continues the work initiated in #109

Changes and Improvements

Resolved merge conflicts present in PR Added scanner command. #109.
Added documentation for the newly introduced commands.

Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

… the creation of the scanner. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Co-authored-by: Aman <136564604+amands98@users.noreply.github.com> Signed-off-by: Muazul Islam <96006730+muaz-32@users.noreply.github.com>

Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

… for auth type. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

…teraction. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 · 2025-04-12T08:20:29Z

@bupd,
The createScanner API is consistently returning an Internal Server Error.
Could you please help identify the reason behind this?

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

bupd · 2025-04-13T14:22:59Z

@bupd, The createScanner API is consistently returning an Internal Server Error. Could you please help identify the reason behind this?

try setting use_internal_addr to true. or use a valid scanner.

rizul2108 · 2025-04-13T14:32:25Z

still same
is url being tested first?

bupd

output yaml/json is not working for view.

./habor-cli scanner list -o yaml doesn't return yaml output.

Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com> Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

rizul2108 · 2025-04-14T05:07:09Z

output yaml/json is not working for view.

./habor-cli scanner list -o yaml doesn't return yaml output.

view cmd is fixed
and for list

it is yaml only i checked with a validator

implement changes Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> view-cmd terminal change fixed Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> lint fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

bupd

I have left my suggestions for improvements. feel free to go through slowly and update the PR.

Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

2 changes implemented Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> fix create view Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> get scanners by name and fixes Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> improve desc and docs of cmds Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> small fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> small fixes in url Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> small fixes in url Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

bupd

lgtm

rizul2108 · 2025-05-12T10:54:35Z

@Vad1mo ready to merge

Vad1mo · 2025-05-13T05:51:45Z

@rizul2108 Can you resolve the merge conflicts

Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>

* Added `scanner create` command. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> * Improved the `scanner create` command. It tests the connection before the creation of the scanner. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> * Update pkg/api/scanner_handler.go Co-authored-by: Aman <136564604+amands98@users.noreply.github.com> Signed-off-by: Muazul Islam <96006730+muaz-32@users.noreply.github.com> * Added the code review suggestions. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> * Added the `view` command for scanner. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> * Added the `metadata` command for scanner. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> * Added the `set-default` command for scanner. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> * Added the `delete` command for scanner. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> * Added the `update` command for scanner and fixed the `create` command for auth type. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> * Added the `ping` option while creating scanner to mimic the web UI interaction. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> * add header and gofmt Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * add docs Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * lint fixes Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * lint fixes Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * update list cmd Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * add header Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * improve ui Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * fix lint issues Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * Update pkg/views/scanner/list/view.go Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com> Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com> * Update cmd/harbor/root/cmd.go Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com> Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com> * fix: implement changes and apply lint fixes implement changes Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> view-cmd terminal change fixed Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> lint fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * implement changes and update docs 2 changes implemented Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> fix create view Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> get scanners by name and fixes Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> improve desc and docs of cmds Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> small fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> small fixes in url Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> small fixes in url Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> * small fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> --------- Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> Signed-off-by: Muazul Islam <96006730+muaz-32@users.noreply.github.com> Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com> Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com> Co-authored-by: muaz-32 <96006730+muaz-32@users.noreply.github.com> Co-authored-by: Aman <136564604+amands98@users.noreply.github.com> Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com>

muaz-32 and others added 16 commits June 4, 2024 20:05

Added scanner create command.

b27a676

Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Improved the scanner create command. It tests the connection before…

6145a99

… the creation of the scanner. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Update pkg/api/scanner_handler.go

011fbee

Co-authored-by: Aman <136564604+amands98@users.noreply.github.com> Signed-off-by: Muazul Islam <96006730+muaz-32@users.noreply.github.com>

Added the code review suggestions.

1164f30

Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Added the view command for scanner.

2c319c5

Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Added the metadata command for scanner.

0ca2656

Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Added the set-default command for scanner.

a8ea7e8

Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Added the delete command for scanner.

e8e2199

Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Added the update command for scanner and fixed the create command…

136a8d5

… for auth type. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Added the ping option while creating scanner to mimic the web UI in…

eececca

…teraction. Signed-off-by: muaz-32 <96006730+muaz-32@users.noreply.github.com>

Merge branch 'main' into scanner-cmd

7746681

add header and gofmt

110474f

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

add docs

65c85ef

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

lint fixes

927ac5b

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

lint fixes

ae372f0

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

update list cmd

ac5c0d7

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 added 3 commits April 12, 2025 13:59

add header

63f05f1

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

improve ui

83445a5

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

fix lint issues

a904e2c

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

bupd requested changes Apr 13, 2025

View reviewed changes

rizul2108 and others added 2 commits April 13, 2025 20:31

Update pkg/views/scanner/list/view.go

c6492d6

Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com> Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

Update cmd/harbor/root/cmd.go

0b47ef2

Co-authored-by: Prasanth Baskar <bupdprasanth@gmail.com> Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

fix: implement changes and apply lint fixes

9b3cf54

implement changes Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> view-cmd terminal change fixed Signed-off-by: Rizul Gupta <mail2rizul@gmail.com> lint fix Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 force-pushed the scanner-cmd branch from 5c5a6bf to 9b3cf54 Compare April 14, 2025 05:34

bupd requested changes Apr 15, 2025

View reviewed changes

Merge branch 'main' into scanner-cmd

1dddf42

Signed-off-by: Rizul Gupta <112455393+rizul2108@users.noreply.github.com>

Vad1mo changed the title ~~Continuing Work from #109 : add scanner cmd~~ Add scanner cmd Apr 29, 2025

rizul2108 added 2 commits May 6, 2025 07:31

Merge branch 'main' into scanner-cmd

087781c

rizul2108 force-pushed the scanner-cmd branch from c99338a to 3e15892 Compare May 6, 2025 10:36

small fix

c4b5543

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

rizul2108 requested a review from bupd May 6, 2025 11:18

bupd approved these changes May 6, 2025

View reviewed changes

bupd added the enhancement New feature or request label May 6, 2025

Merge branch 'main' into scanner-cmd

5a4e255

Merge branch 'main' into scanner-cmd

d5b1ecc

Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>

Vad1mo merged commit 4ace830 into goharbor:main May 13, 2025
7 checks passed

rizul2108 deleted the scanner-cmd branch May 14, 2025 18:48

Conversation

rizul2108 commented Apr 12, 2025

Description

Changes and Improvements

Uh oh!

rizul2108 commented Apr 12, 2025

Uh oh!

bupd commented Apr 13, 2025

Uh oh!

rizul2108 commented Apr 13, 2025

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rizul2108 commented Apr 14, 2025

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

rizul2108 commented May 12, 2025

Uh oh!

Vad1mo commented May 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants