Adds harbor context command#445
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new harbor context command to manage and switch contexts by reading/writing from a configuration file.
- Introduces a new command (harbor context list) for listing contexts
- Adds a new view for rendering the context list
- Creates additional API types to support the context functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/views/context/list/view.go | Adds a view to render the list of contexts using a table |
| pkg/api/types.go | Introduces the ContextListView type |
| cmd/harbor/root/context/list.go | Implements the cobra command for listing contexts |
| cmd/harbor/root/context/cmd.go | Adds a context command to the overall CLI command hierarchy |
| cmd/harbor/root/cmd.go | Integrates the new context command into the root command collection |
Comments suppressed due to low confidence (1)
cmd/harbor/root/context/list.go:38
- [nitpick] Consider using named field initialization for ContextListView for improved clarity and maintainability (e.g., ContextListView{Name: cred.Name, Username: cred.Username, Server: cred.ServerAddress}).
cx := api.ContextListView{cred.Name, cred.Username, cred.ServerAddress}
|
@Vad1mo Should I continue working on this and add |
796d3b5 to
e7a47c5
Compare
|
@Darkhood148 rebase onto main branch |
bupd
left a comment
There was a problem hiding this comment.
@Darkhood148 Thanks for your contributions
I have added some suggestion for improvements
Also rebase & run dagger call lint. and fix the lint issues
Thanks
370ad74 to
844a9ae
Compare
|
@bupd Done the changes. |
bupd
left a comment
There was a problem hiding this comment.
Thanks for your contributions
I have added suggestions please fix that.
08968e0 to
9748046
Compare
|
Done with the changes @bupd ! if !term.IsTerminal(int(os.Stdout.Fd())) {
opts = append(opts, tea.WithoutRenderer(), tea.WithInput(nil))
}After adding this, the same test passes! |
9748046 to
86b7e6f
Compare
61908d1 to
d2982a4
Compare
|
Furthermore, we should only have one way to switch the context, so we should remove |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
3bc6fca to
b89520c
Compare
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
|
Rename |
|
Mybe provide an output after context switch e..g switched context from x to y. |
* adds harbor context command Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * Update cmd/harbor/root/context/list.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com> * renames config to context Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * linting changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * documentation changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * test changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * readd test; handle non-tty in bubble tea Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * rebase and lint Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * rebase and lint Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * rebase and lint Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * highlight active user Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * adds context switch command Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * updates logging Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * updates context switch Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * Update cmd/harbor/root/context/delete.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com> * Update cmd/harbor/root/context/cmd.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com> * minor change Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * rebasing Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * doc changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * linting changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * updates docs Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> --------- Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* adds harbor context command Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * Update cmd/harbor/root/context/list.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com> * renames config to context Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * linting changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * documentation changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * test changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * readd test; handle non-tty in bubble tea Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * rebase and lint Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * rebase and lint Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * rebase and lint Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * highlight active user Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * adds context switch command Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * updates logging Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * updates context switch Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * Update cmd/harbor/root/context/delete.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com> * Update cmd/harbor/root/context/cmd.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com> * minor change Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * rebasing Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * doc changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * linting changes Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> * updates docs Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> --------- Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com> Signed-off-by: Ujjwal Sharma <68021601+Darkhood148@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>






Related Issue:
#417
Description:
Adds harbor context command to manage and switch context by reading/writing from
confg.yaml