fix: Update OCI registry publishing in release workflow - #2294
Conversation
c8fac53 to
c59accd
Compare
There was a problem hiding this comment.
Thanks @TerryHowe
I believe we should fix the env vars rather than removing the dockerhub push.
looks like this has been failing for a past couple of months
|
@MinerYang thoughts ?? |
|
Heya @bupd been a minute. I was thinking delivering charts to ghcr would almost certain work and that would unblock the problem. If someone really wants to deliver to docker.io, that could be a follow up. |
|
Sorry everyone, I was just back from a sick leave. Will take a look recently. |
|
ping |
|
cc // @MinerYang |
|
Is there anything else we need to do to get this merged? I'd very much like to use the OCI registry as the helm repository reference |
a8bd432 to
8c60b29
Compare
|
@cthtrifork , is this now good to go from your perspective? |
I am not the maintainer, but let us know if we can further! |
|
@MinerYang is there anything left to do in order to get this merged? |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions release workflow to publish the Helm chart as an OCI artifact to GitHub Container Registry (GHCR), addressing failures caused by incorrect registry targets and missing credentials for Docker Hub.
Changes:
- Removes Docker Hub OCI login/push from the release workflow.
- Updates the GHCR OCI push target from the triggering user namespace to the repository owner namespace.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove Docker Hub push that fails with authentication errors due to missing credentials. Fix GHCR push to use GITHUB_REPOSITORY_OWNER for the organization path instead of github.actor. Closes goharbor#2265 Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
984f605 to
8e50523
Compare
Description
This PR fixes the OCI registry publishing issue in the release workflow.
Changes
ghcr.io/goharbor) instead of personal account (ghcr.io/${{ github.actor }})GITHUB_TOKENwhich is available in GitHub ActionsFixes
Closes #2265