Skip to content

Allow configuring registries for proxy cache and replication whitelist - #2305

Open
fernandocarletti wants to merge 1 commit into
goharbor:mainfrom
fernandocarletti:main
Open

Allow configuring registries for proxy cache and replication whitelist#2305
fernandocarletti wants to merge 1 commit into
goharbor:mainfrom
fernandocarletti:main

Conversation

@fernandocarletti

Copy link
Copy Markdown

The PR #2223 changed these environment variables, but removing quay specifically affected some users.

I did not add more documentation to the entries because not even the Harbor codebase documented them well, although they seem very straight forward to understand.

…DAPTER_WHITELIST configurable via values

Signed-off-by: Fernando Carletti <fernando@carletti.dev>
@asfalots

Copy link
Copy Markdown

Small comment to bump it. We are affected as well by quay removal and we need this PR :-)

@lbi22

lbi22 commented Feb 26, 2026

Copy link
Copy Markdown

We are affected as well

@marevers

Copy link
Copy Markdown

Also noticed this change, I assume there is a reason for removing Quay from the standard list but at any rate, it should be configurable (possibly with the new default).

isityael added a commit to isityael/harbor-helm that referenced this pull request Mar 16, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@lbi22

lbi22 commented Mar 19, 2026

Copy link
Copy Markdown

Any news on this?

isityael added a commit to isityael/harbor-helm that referenced this pull request Apr 14, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isityael added a commit to isityael/harbor-helm that referenced this pull request Apr 14, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isityael added a commit to isityael/harbor-helm that referenced this pull request Apr 14, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isityael added a commit to isityael/harbor-helm that referenced this pull request Apr 14, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: make PERMITTED_REGISTRY_TYPES_FOR_PROXY_CACHE and REPLICATION_ADAPTER_WHITELIST configurable via values

Signed-off-by: Fernando Carletti <fernando@carletti.dev>

docs: add PRs goharbor#2289, goharbor#2305 to cherry-picked list

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isityael added a commit to isityael/harbor-helm that referenced this pull request Apr 14, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: make PERMITTED_REGISTRY_TYPES_FOR_PROXY_CACHE and REPLICATION_ADAPTER_WHITELIST configurable via values

Signed-off-by: Fernando Carletti <fernando@carletti.dev>

docs: add PRs goharbor#2289, goharbor#2305 to cherry-picked list

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isityael added a commit to isityael/harbor-helm that referenced this pull request Apr 14, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: make PERMITTED_REGISTRY_TYPES_FOR_PROXY_CACHE and REPLICATION_ADAPTER_WHITELIST configurable via values

Signed-off-by: Fernando Carletti <fernando@carletti.dev>

docs: add PRs goharbor#2289, goharbor#2305 to cherry-picked list

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isityael added a commit to isityael/harbor-helm that referenced this pull request Apr 14, 2026
Add .vscode/, .woodpecker/, CLAUDE.md to helmignore so they
don't get packaged into the OCI artifact.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

docs: add PR goharbor#2289 to cherry-picked list

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: make PERMITTED_REGISTRY_TYPES_FOR_PROXY_CACHE and REPLICATION_ADAPTER_WHITELIST configurable via values

Signed-off-by: Fernando Carletti <fernando@carletti.dev>

docs: add PRs goharbor#2289, goharbor#2305 to cherry-picked list

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chore(deps): update woodpeckerci/plugin-release docker digest to caf18bc

chore(deps): update module github.com/gruntwork-io/terratest to v0.56.0 (#3)

Co-authored-by: Renovate Bot <renovate@m0sh1.cc>
chore(deps): update dhi.io/helm:4.1.3-debian13-dev docker digest to b604d0b

chore(deps): update module k8s.io/api to v0.35.2

chore(deps): update dhi.io/helm:4.1.3-debian13-dev docker digest to 0a68e1a (#6)
build: bump chart to 1.19.0 / appVersion v2.15.0 GA

Harbor v2.15.0 has been released as the latest upstream stable.
All 8 cherry-picked helm PRs are still unmerged upstream.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chore(deps): update module k8s.io/api to v0.35.3 (#7)

Co-authored-by: Renovate Bot <renovate@m0sh1.cc>
chore(deps): update dhi.io/helm:4.1.3-debian13-dev docker digest to 0e15ecf (#8)

Co-authored-by: Renovate Bot <renovate@m0sh1.cc>
chore: bump chart version to 1.19.1

OCI registries treat versions as immutable — 1.19.0 was published with
appVersion v2.15.0-rc2. Bump to 1.19.1 so the v2.15.0 GA appVersion
is published as a new artifact.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chore: remove deprecated engine field, enable auto release notes

- Remove `engine: gotpl` from Chart.yaml (deprecated since Helm 3,
  causes strict parse warning)
- Add `note: "auto"` to release plugin so GitHub releases get
  auto-generated release notes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chore(deps): update woodpeckerci/plugin-release docker digest to 284b612 (#10)

Co-authored-by: Renovate Bot <renovate@m0sh1.cc>
chore(deps): update dhi.io/helm:4.1.3-debian13-dev docker digest to 211bc06 (#11)

Co-authored-by: Renovate Bot <renovate@m0sh1.cc>
chore(deps): update woodpeckerci/plugin-release docker digest to 397f161 (#12)

Co-authored-by: Renovate Bot <renovate@m0sh1.cc>
chore(deps): update woodpeckerci/plugin-release docker digest to b178a16 (#13)

Co-authored-by: Renovate Bot <renovate@m0sh1.cc>
fix: null rollingUpdate field when strategy is Recreate

Cherry-picked from upstream goharbor/harbor-helm main. Kubernetes
rejects switching strategy from RollingUpdate to Recreate unless the
rollingUpdate field is explicitly set to null.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

build: bump chart to 1.19.2

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chore(deps): update dhi.io/helm:4.1.3-debian13-dev docker digest to 8649155 (#14)

Co-authored-by: Renovate Bot <renovate@m0sh1.cc>
chore(deps): update dhi.io/helm docker tag to v4.1.4-debian13-dev (#15)

Co-authored-by: Renovate Bot <renovate@m0sh1.cc>
chore(deps): update woodpeckerci/plugin-release docker digest to 9d61f12 (#16)
fix: remove duplicate entries in values.yaml (goharbor#2338)

Signed-off-by: thomas <thomas.zawisza@hotmail.fr>
@github-actions

Copy link
Copy Markdown

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions Bot added the Stale label May 18, 2026
@fernandocarletti

Copy link
Copy Markdown
Author

Just commenting to avoid the auto-close. It would be nice to have this fix.

@github-actions github-actions Bot removed the Stale label May 20, 2026
@github-actions

Copy link
Copy Markdown

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions Bot added the Stale label Jul 20, 2026
@fernandocarletti

Copy link
Copy Markdown
Author

Not stale.

@github-actions github-actions Bot removed the Stale label Jul 21, 2026
@sanchpet

Copy link
Copy Markdown

Bump, kinda affected too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants