feat(nginx): add loadBalancerClass support to LB svc - #2359
Open
mlguerrero12 wants to merge 1 commit into
Open
Conversation
Add spec.loadBalancerClass rendering to the nginx Service template when expose.type=loadBalancer. The field is omitted when unset, preserving backward compatibility for existing deployments. Signed-off-by: Marcelo Guerrero <marcegue@cisco.com>
mlguerrero12
force-pushed
the
addloadbalancerclass
branch
from
May 2, 2026 09:55
5c37ca9 to
341045f
Compare
Author
|
@MinerYang PTAL. Thanks! |
Collaborator
Hi @mlguerrero12 , Sorry for the late response. Could you also help to write a UT for this specific case? Thanks^ |
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add spec.loadBalancerClass rendering to the nginx Service template when expose.type=loadBalancer. The field is omitted when unset, preserving backward compatibility for existing deployments.