Skip to content

Template annotations in all major harbor components [take two] - #2360

Open
nepomucen wants to merge 5 commits into
goharbor:mainfrom
nepomucen:add/annotations-v2
Open

Template annotations in all major harbor components [take two]#2360
nepomucen wants to merge 5 commits into
goharbor:mainfrom
nepomucen:add/annotations-v2

Conversation

@nepomucen

Copy link
Copy Markdown

What does this change resolve?

  • it allows users the add annotations to each harbor's component Deployment.

Example use case:
Users of stakater/Reloader can now specify annotations to the various Harbor components, to let reloader perform a rolling upgrade on related Deployment's pods when secret specified in annotation is updated.

Testing

 helm template . --set core.annotations."secret\.reloader\.stakater\.com/reload"="custom-harbor-secret" | grep -A 9 core-dpl.yaml
# Source: harbor/templates/core/core-dpl.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: release-name-harbor-core
  namespace: "website-operator"
  annotations:
    secret.reloader.stakater.com/reload: custom-harbor-secret
  labels:
    heritage: Helm

nepomucen added 5 commits May 5, 2026 10:22
Signed-off-by: nepomucen <szymon@aus.krakow.pl>
Signed-off-by: nepomucen <szymon@aus.krakow.pl>
Signed-off-by: nepomucen <szymon@aus.krakow.pl>
Signed-off-by: nepomucen <szymon@aus.krakow.pl>
Signed-off-by: nepomucen <szymon@aus.krakow.pl>
@Sea-you

Sea-you commented May 29, 2026

Copy link
Copy Markdown

@MinerYang It's really something that we need. Would you mind to take a look please?

@Dentling

Dentling commented Jul 7, 2026

Copy link
Copy Markdown

I also need this feature.

@MinerYang could you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants