Skip to content

allow extraVolumes and extraVolumeMounts on core#911

Closed
mcmartins wants to merge 2 commits into
goharbor:1.6.0from
mcmartins:1.6.0
Closed

allow extraVolumes and extraVolumeMounts on core#911
mcmartins wants to merge 2 commits into
goharbor:1.6.0from
mcmartins:1.6.0

Conversation

@mcmartins

Copy link
Copy Markdown

We've deployed harbor using helm 3 on a 1.18 Kubernetes cluster:

NAME  	NAMESPACE	REVISION	UPDATED                                	STATUS  	CHART       	APP VERSION
harbor	harbor   	7       	2021-03-24 10:36:22.909063483 +0000 UTC	deployed	harbor-1.6.0	2.2.0      

Our storage for the registry, chartmuseum and jobservice is a NFS (ReadWriteMany) solution.

When we access the GUI, the storage gauge on the right appears with a NaN GB.

When using a ReadWriteMany storage solution, I believe this solves this issue: API api/systeminfo/volumes does't work #441

By mounting the same storage as extraVolume on the core component:

core:
  image:
    repository: goharbor/harbor-core
    tag: v2.2.0
    ...
    # Extra volumes to add to the deployment
    extraVolumes:
      - name: registry-data
        persistentVolumeClaim:
          claimName: nfs-harbor-dev-pvc
    # Extra volume mounts to add to the container
    extraVolumeMounts:
      - mountPath: /data
        name: registry-data
        subPath: core

Thanks,
Manuel

Signed-off-by: Manuel Martins <Manuel.Martins@ecmwf.int>
@mcmartins

Copy link
Copy Markdown
Author

Just looking around now and I believe the Pull Request Add extra configuration parameters #558 includes this one, so I'm happy if this one is ignored and the #558 is progressed ;)

@rgarcia89

Copy link
Copy Markdown
Contributor

Where are we with this MR?
I could also need this to mount secrets via the Hashicorp Vault CSI into the core.

@Kajot-dev

Copy link
Copy Markdown
Contributor

We could allow this also on portal containers since there is "setting.json" inside which could be modified that way

@github-actions

github-actions Bot commented Apr 7, 2024

Copy link
Copy Markdown

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions Bot added the Stale label Apr 7, 2024
@github-actions

github-actions Bot commented May 7, 2024

Copy link
Copy Markdown

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions Bot closed this May 7, 2024
@Jacq

Jacq commented Apr 16, 2026

Copy link
Copy Markdown

This looked promising but was never merged nor rejected, this approach could be apply for all components, for trivy it has been just merged in #2350.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants