lowercase value of metric enable when migrate from old to new version#22580
Open
thuvh wants to merge 1 commit intogoharbor:mainfrom
Open
lowercase value of metric enable when migrate from old to new version#22580thuvh wants to merge 1 commit intogoharbor:mainfrom
thuvh wants to merge 1 commit intogoharbor:mainfrom
Conversation
f7efc93 to
832b3cd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22580 +/- ##
===========================================
+ Coverage 45.36% 65.84% +20.47%
===========================================
Files 244 1073 +829
Lines 13333 116095 +102762
Branches 2719 2931 +212
===========================================
+ Hits 6049 76446 +70397
- Misses 6983 35409 +28426
- Partials 301 4240 +3939
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c0c5bce to
89cce95
Compare
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Author
|
@MinerYang @stonezdj @Vad1mo please review for me |
89cce95 to
6d62c56
Compare
Signed-off-by: Hoai-Thu Vuong <thuvh87@gmail.com>
6d62c56 to
d46b2cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
when migrate from old to new version with enabled metric,
harbor.ymlis generated likeIssue being fixed
n/a
Please indicate you've done the following: