Skip to content

lowercase value of metric enable when migrate from old to new version#22580

Open
thuvh wants to merge 1 commit intogoharbor:mainfrom
thuvh:prepare_metric_enabled_lowercase
Open

lowercase value of metric enable when migrate from old to new version#22580
thuvh wants to merge 1 commit intogoharbor:mainfrom
thuvh:prepare_metric_enabled_lowercase

Conversation

@thuvh
Copy link

@thuvh thuvh commented Nov 20, 2025

Thank you for contributing to Harbor!

when migrate from old to new version with enabled metric, harbor.yml is generated like

metric:
  enabled: True

Issue being fixed

n/a

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@thuvh thuvh requested a review from a team as a code owner November 20, 2025 06:16
@thuvh thuvh force-pushed the prepare_metric_enabled_lowercase branch from f7efc93 to 832b3cd Compare November 20, 2025 06:17
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.84%. Comparing base (c8c11b4) to head (832b3cd).
⚠️ Report is 595 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22580       +/-   ##
===========================================
+ Coverage   45.36%   65.84%   +20.47%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116095   +102762     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76446    +70397     
- Misses       6983    35409    +28426     
- Partials      301     4240     +3939     
Flag Coverage Δ
unittests 65.84% <ø> (+20.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 987 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thuvh thuvh force-pushed the prepare_metric_enabled_lowercase branch from c0c5bce to 89cce95 Compare January 14, 2026 09:34
@github-actions
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Mar 16, 2026
@thuvh
Copy link
Author

thuvh commented Mar 16, 2026

@MinerYang @stonezdj @Vad1mo please review for me

@github-actions github-actions bot removed the Stale label Mar 17, 2026
@thuvh thuvh force-pushed the prepare_metric_enabled_lowercase branch from 89cce95 to 6d62c56 Compare March 19, 2026 03:57
Signed-off-by: Hoai-Thu Vuong <thuvh87@gmail.com>
@thuvh thuvh force-pushed the prepare_metric_enabled_lowercase branch from 6d62c56 to d46b2cc Compare March 19, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants