[CHERRY_PICK] fix(session): fix SessionRegenerate save args and lifetime#22882
Merged
chlins merged 1 commit intogoharbor:release-2.14.0from Mar 20, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.14.0 #22882 +/- ##
=================================================
Coverage ? 65.86%
=================================================
Files ? 1072
Lines ? 116078
Branches ? 2931
=================================================
Hits ? 76458
Misses ? 35384
Partials ? 4236
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: chlins <chlins.zhang@gmail.com>
d896858 to
2aec3da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
It's a cherry pick of #22873 and #22726.
This pull request makes improvements to session regeneration handling and enhances test coverage for session management. The main changes ensure that empty session data is stored with the correct type and add additional tests to verify session regeneration behavior.
Session regeneration improvements:
SessionRegenerateinsession.goto store empty session data as a map instead of an empty string, ensuring correct session data type and consistency.Session management test enhancements:
TestSessionRegenerateinsession_test.goto test session regeneration for a new session ID (session-004), verifying that the session is properly created and exists after regeneration.Issue being fixed
Fixes #(issue)
Please indicate you've done the following: