Skip to content

Fix automatic summary container balancing#14927

Open
puneetdixit200 wants to merge 1 commit into
gohugoio:masterfrom
puneetdixit200:fix-summary-balanced-html
Open

Fix automatic summary container balancing#14927
puneetdixit200 wants to merge 1 commit into
gohugoio:masterfrom
puneetdixit200:fix-summary-balanced-html

Conversation

@puneetdixit200

Copy link
Copy Markdown

Summary

  • keep automatic summaries from splitting blockquote, list, and HTML container tags when the word cutoff lands inside them
  • extend the automatic summary cutoff to the matching closing tag before ContentWithoutSummary starts
  • add unit and integration coverage for blockquotes, lists, and HTML containers

Fixes #14044

Tests

  • GOMODCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gomodcache GOCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gocache go test ./resources/page -run TestExtractSummaryFromHTML -count=1
  • GOMODCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gomodcache GOCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gocache go test ./hugolib -run TestSummaryAutoBalancesContainerTags -count=1
  • GOMODCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gomodcache GOCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gocache go test ./resources/page ./hugolib -count=1
  • GOMODCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gomodcache GOCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gocache GOBIN=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gobin PATH=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gobin:$PATH ./check.sh ./resources/page
  • GOMODCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gomodcache GOCACHE=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gocache GOBIN=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gobin PATH=/Users/deepakkudi23/ai-resume-contrib-100/hugo-cache/gobin:$PATH ./check.sh ./hugolib
  • git diff --check

AI Assistance

I used AI assistance to help prepare this narrow bug fix. I reviewed the implementation and tests before submitting.

@gemini-code-assist

Copy link
Copy Markdown
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@CLAassistant

CLAassistant commented May 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic summary may generate invalid HTML with blockquotes and lists

3 participants