Use short token for code highlighting#5350
Use short token for code highlighting#5350stephenfin wants to merge 1 commit intogohugoio:masterfrom
Conversation
69c505e to
32922c5
Compare
stephenfin
left a comment
There was a problem hiding this comment.
Whoops. Looks like something's off here
32922c5 to
8036447
Compare
|
I don't know enough about RsT to merge this. I'm mostly concerned if this new flag will somehow break in some RsT versions. @anthonyfok any input? others? |
|
Looks like there's now a merge conflict because the location of this code changed. If I were to rebase this PR, would that be somethign that could merged, or are there larger concerns? |
|
I've rebased this. It's definitely safe |
|
This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help. |
|
This is still valid. Let me know if I can help explain anything |
|
@stephenfin looks like there's a merge conflict to resolve here. |
|
As I said, I don't know enough about this to review this. |
Signed-off-by: Stephen Finucane <stephen@that.guru> Closes: gohugoio#5349
37685f7 to
9cfdd9c
Compare
Closes: #5349
As noted in #5349,
rst2htmlcan generate HTML with short or long form class names for syntax highlighting. Pygments (via thepygmentizecommand) seems to generate short form by default without any way to switch this. This means most/any stylesheets for code provided with various themes won't work when using rST output. This can easily be fixed by providing the--syntax-highlight=shortflag torst2html.