feat: eliminate Go sidecar, send gRPC events directly to webhook plugin#113
Draft
VivekPipaliya23 wants to merge 3 commits into
Draft
feat: eliminate Go sidecar, send gRPC events directly to webhook plugin#113VivekPipaliya23 wants to merge 3 commits into
VivekPipaliya23 wants to merge 3 commits into
Conversation
Replace the vernemq-events-sidecar Go service (TCP protobuf → gRPC translator) with direct gRPC calls from the Erlang plugin to the webhook plugin using emqx/grpc-erl. This removes a network hop and an entire service from the deployment, while keeping the webhook plugin unchanged. Key changes: - Replace shackle TCP client with grpc-erl gRPC client (grpc_client:unary/4) - Add full webhook service proto (PluginService.Event) to vmq_proto - Send user-type as gRPC metadata header instead of sidecar config - Fire-and-forget via spawn/1 around synchronous gRPC call - Update config schema: grpc_endpoint, grpc_port, grpc_pool_size, grpc_timeout, user_type replace hostname, port, pool_size, backlog_size - Rewrite test infrastructure: gRPC server handler replaces TCP server Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the vernemq-events-sidecar Go service (TCP protobuf → gRPC translator) with direct gRPC calls from the Erlang plugin to the webhook plugin using emqx/grpc-erl. This removes a network hop and an entire service from the deployment, while keeping the webhook plugin unchanged.
Key changes:
Proposed Changes
Please describe the big picture of your changes here to communicate to the
VerneMQ team why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CODE_OF_CONDUCT.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.