Skip to content

fix: gok vm: use cpu:host instead of named variants #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damdo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: gok vm: use cpu:host instead of named variants #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/gok/vmrun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func (r *vmRunConfig) runQEMU(ctx context.Context, fullDiskImage string, extraAr
case "arm64":
qemu.Args = append(qemu.Args,
"-machine", "virt,highmem=off",
"-cpu", "cortex-a72",
"-cpu", "host",

@stapelberg stapelberg Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, -cpu=host does not work for me?

% qemu-system-aarch64 -name dr -boot order=d -drive file=/tmp/gokrazy-vm1161502338,format=raw -device i6300esb,id=watchdog0 -watchdog-action reset -smp 32 -device e1000,netdev=net0 -netdev user,id=net0,hostfwd=tcp::8080-:80,hostfwd=tcp::8022-:22 -m 1024 -machine virt,highmem=off -cpu cortex-a72 -bios /tmp/gokrazy-vm1861489883/arm64-QEMU_EFI.fd
^Cqemu: terminating on signal 2

% qemu-system-aarch64 -name dr -boot order=d -drive file=/tmp/gokrazy-vm1161502338,format=raw -device i6300esb,id=watchdog0 -watchdog-action reset -smp 32 -device e1000,netdev=net0 -netdev user,id=net0,hostfwd=tcp::8080-:80,hostfwd=tcp::8022-:22 -m 1024 -machine virt,highmem=off -cpu host -bios /tmp/gokrazy-vm1861489883/arm64-QEMU_EFI.fd      
qemu-system-aarch64: unable to find CPU model 'host'

"-bios", arm64EFI)

case "amd64":
Expand Down
Loading