feat: add required issued-at validation option#520
Open
happysnaker wants to merge 2 commits into
Open
Conversation
Author
|
Quick follow-up: I pushed a tiny formatting-only commit after checking the failed build logs. The actual failure was just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithIssuedAtRequired()to require theiatclaim while also enabling issued-at validationrequireIatvalidator setting through claim validationiatclaimsWhy
Issue #489 points out that
WithIssuedAt()validates futureiatvalues but still leaves the claim optional, unlike the existing required-claim options such asWithExpirationRequired()andWithNotBeforeRequired().This change keeps the current
WithIssuedAt()behavior intact for callers that only want the sanity check, while providing an explicit option for callers that wantiatto be mandatory.Closes #489