Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Couchbase database driver to migrate/v4, intended to support N1QL-based JSON migrations, scope/collection configuration, and advisory locking, plus CLI build-tag wiring and integration tests.
Changes:
- Introduces
database/couchbasedriver implementation with URL parsing, migration execution, versioning, and locking. - Adds Couchbase docker-based integration tests and example JSON migration files.
- Wires Couchbase into CLI build tags and Makefile, and updates
go.mod/go.sum(including a localdktestreplace).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/cli/build_couchbase.go | Adds build-tagged blank import to include Couchbase driver in CLI builds. |
| database/couchbase/couchbase.go | New Couchbase driver implementation (Open/Run/Lock/Version/Drop/etc.). |
| database/couchbase/couchbase_test.go | Adds docker-based integration tests for Couchbase 7.6.2 and 8.0.0. |
| database/couchbase/examples/migrations/*.json | Adds example N1QL JSON migration files. |
| Makefile | Adds couchbase to the DATABASE build tag list. |
| go.mod | Updates Go version/deps and adds replace github.com/dhui/dktest => ./_dktest_local. |
| go.sum | Adds checksums for newly introduced/upgraded dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new database driver for Couchbase Server supporting:
Includes local fork of dktest with two fixes needed for
Docker-based integration tests:
Tested against couchbase:community-7.6.2 and community-8.0.0.