Open
Conversation
added 2 commits
March 29, 2026 12:46
…res driver When host is specified as a query parameter (e.g., ?host=/var/run/postgresql) and the URL has no host in the authority section, convert the connection string to key-value format via pq.ParseURL before passing to sql.Open. This ensures lib/pq reliably uses the host parameter instead of silently falling back to localhost:5432. The pgx/v5 driver handles this correctly because pgx.ParseConfig natively supports host as a query parameter. This change brings the postgres (lib/pq) driver to parity. (gm-6mx)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
source_issue: gm-6mx
branch: polecat/wren/gm-6mx@mnc5pcna
target: master
rig: golangmigrate
strategy: fork
commit_sha: db7f224
worker: wren