fix: handle host query parameter for unix socket connections#1378
Open
quad341 wants to merge 1 commit intogolang-migrate:masterfrom
Open
fix: handle host query parameter for unix socket connections#1378quad341 wants to merge 1 commit intogolang-migrate:masterfrom
quad341 wants to merge 1 commit intogolang-migrate:masterfrom
Conversation
…res driver When host is specified as a query parameter (e.g., ?host=/var/run/postgresql for unix socket connections) and the URL has no host in the authority section, lib/pq silently connects to localhost:5432 instead. Convert to key-value connection string so the host parameter is reliably used. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostis specified as a query parameter (e.g.,?host=/var/run/postgresqlfor unix socket connections) and the URL has no host in the authority section,lib/pqsilently connects tolocalhost:5432instead of the specified socket pathlib/pqreliably uses itTest plan
testHostQueryParamtest that connects usingpostgres:///db?host=<ip>&port=<port>format🤖 Generated with Claude Code