Open
Conversation
Introduce a new database driver for Firebolt (https://www.firebolt.io/), using the official firebolt-go-sdk v1.20.0. The driver implements the full database.Driver contract: version tracking via an append-only migrations table (BIGINT version, BOOLEAN dirty, BIGINT sequence), in-process locking, multi-statement migration support, and DROP via information_schema.tables. Integration tests use dktest with the Firebolt Core Docker image (ghcr.io/firebolt-db/firebolt-core:preview-rc), following the same pattern as Postgres and other Docker-based drivers. Notable implementation detail: the Open() method reconstructs the DSN manually instead of using url.URL.String(), because Go drops the "//" authority separator from "firebolt://" when both Host and Path are empty, which the Firebolt SDK's regex-based parser rejects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new database driver for Firebolt, using the official firebolt-go-sdk v1.20.0.
The driver implements the full
database.Drivercontract: version tracking via an append-only migrations table (BIGINT version, BOOLEAN dirty, BIGINT sequence), in-process locking, multi-statement migration support, and DROP via information_schema.tables.Integration tests use dktest with the Firebolt Core Docker image (
ghcr.io/firebolt-db/firebolt-core:preview-rc), following the same pattern as Postgres and other Docker-based drivers.Notable implementation detail: the Open() method reconstructs the DSN manually instead of using url.URL.String(), because Go drops the "//" authority separator from "firebolt://" when both Host and Path are empty, which the Firebolt SDK's regex-based parser rejects.
NOTE: this change also bumps Go version from 1.24.0 to 1.24.9, since firebolt-go-sdk uses 1.24.9