cmd/gopherbot: change issue notification comment to include author name#10
cmd/gopherbot: change issue notification comment to include author name#10kzisme wants to merge 2 commits intogolang:masterfrom
Conversation
|
Message from Gerrit User 12446: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28643: Patch Set 2: Code-Review+1 LGTM Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 5065: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 5065: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 12446: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 12446: Uploaded patch set 4: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 12446: Uploaded patch set 5: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28622: Patch Set 6: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28622: Patch Set 6: (1 comment) Are there any other changes/tweaks I should be making to these commit(s)? Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 5065: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28962: Patch Set 6: (2 comments)
Hey Kevin, It seems like these two edits are still pending:
Would you have time to make these edits? Julie Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28622: Patch Set 7:
Hey Julie, Sorry for the slight delay. I just pushed a few more changes - please let me know what you think. Thanks, Kevin Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Josh Bleecher Snyder: Patch Set 7: Ping. Anyone want to revive this? I'm excited to see authors in the notifications, and it'd be nice to get this submitted before anyone starts working on golang.org/issue/28839, to avoid unnecessary merge conflicts. Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Kevin Zita: Patch Set 7:
Hello Josh! I'd be more than happy to take another look this weekend if someone can provide some feedback on the previous patch. Cheers! Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Josh Bleecher Snyder: Patch Set 7: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
This PR (HEAD: 405e2fd) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/build/+/127930 to see it. Tip: You can toggle comments from me using the |
|
Message from Kevin Zita: Patch Set 9: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Josh Bleecher Snyder: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28643: Patch Set 2: Code-Review+1 LGTM Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 5065: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 5065: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28622: Patch Set 6: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28622: Patch Set 6: (1 comment) Are there any other changes/tweaks I should be making to these commit(s)? Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 5065: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28962: Patch Set 6: (2 comments)
Hey Kevin, It seems like these two edits are still pending:
Would you have time to make these edits? Julie Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Gerrit User 28622: Patch Set 7:
Hey Julie, Sorry for the slight delay. I just pushed a few more changes - please let me know what you think. Thanks, Kevin Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Josh Bleecher Snyder: Patch Set 7: Ping. Anyone want to revive this? I'm excited to see authors in the notifications, and it'd be nice to get this submitted before anyone starts working on golang.org/issue/28839, to avoid unnecessary merge conflicts. Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Kevin Zita: Patch Set 7:
Hello Josh! I'd be more than happy to take another look this weekend if someone can provide some feedback on the previous patch. Cheers! Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Josh Bleecher Snyder: Patch Set 7: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Kevin Zita: Patch Set 9: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
|
Message from Josh Bleecher Snyder: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/127930. |
Fixes golang/go#26816