-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/printer: remove leftover code from type lists #71940
base: master
Are you sure you want to change the base?
go/printer: remove leftover code from type lists #71940
Conversation
The prev var is set to nil in every loop iteration so the condition to prevent a line break is never true. Functionality originally added in CL 273226 and removed in CL 359135.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: f94d855) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/652137. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/652137. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/652137. |
Message from Ben Chodos: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/652137. |
Message from Ian Lance Taylor: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/652137. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-25T02:28:35Z","revision":"93d2c328aae979fce674c52630ec26d775f02ba0"} Please don’t reply on this GitHub thread. Visit golang.org/cl/652137. |
Message from Ian Lance Taylor: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/652137. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/652137. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/652137. |
The prev var is set to nil in every loop iteration so the condition
to prevent a line break is never true.
Functionality originally added in CL 273226 and removed in CL 359135.