Skip to content

Conversation

@marcosdotps
Copy link

@marcosdotps marcosdotps commented Dec 17, 2025

adjustCgroupGOMAXPROCS derives GOMAXPROCS from the cgroup CPU quota. When the quota is fractional, the current computation rounds up, which can set GOMAXPROCS above the available CPU quota.

Round fractional quotas down instead. Keep the existing minimum of 2 for very small quotas to preserve a baseline level of parallelism.

This reduces contention and CPU throttling in production deployments using fractional CPU quotas.

Proposal: #76835

Fixes #76835

…oupGOMAXPROCS

Change the computation to use floor instead, ensuring GOMAXPROCS never exceeds
the available cgroup CPU quota under fractional values. Fractional CPU limits now round
down, except values less than 2 still round up to 2 to preserve minimum
parallelism.

This reduces contention and CPU throttling observed in production deployments
with fractional CPU quotas.

Proposal: golang#76835

Fixes golang#76835
@gopherbot
Copy link
Contributor

This PR (HEAD: 85d1142) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/730601.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/730601.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/730601.
After addressing review feedback, remember to publish your drafts!

@marcosdotps marcosdotps changed the title runtime: use floor instead of ceil for cgroup CPU limits in adjustCgroupGOMAXPROCS runtime: floor cgroup CPU limits in adjustCgroupGOMAXPROCS Dec 17, 2025
@marcosdotps
Copy link
Author

Evidences

Before change

before

After change

after

@gopherbot
Copy link
Contributor

Message from Marcos P. Sánchez:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/730601.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proposal: runtime: adjustCgroupGOMAXPROCS should return floor and not ceil when using fractional CPU limits

2 participants