Skip to content

runtime: fix bitmap marking to exclude ASAN redzone#80180

Open
qinlonglong123 wants to merge 1 commit into
golang:masterfrom
qinlonglong123:asanredfix
Open

runtime: fix bitmap marking to exclude ASAN redzone#80180
qinlonglong123 wants to merge 1 commit into
golang:masterfrom
qinlonglong123:asanredfix

Conversation

@qinlonglong123

@qinlonglong123 qinlonglong123 commented Jun 27, 2026

Copy link
Copy Markdown

When ASAN is enabled, a redzone is appended to allocation size by the compiler-rt.
This causes dataSize to be larger than the actual user data size, which affects
bitmap calculation when the redzone size is comparable to or larger than typ.Size_.

To fix this, use actualSize() to subtract the redzone size before computing the
bitmap mask and scanSize, ensuring only the actual user data region is reflected
in the bitmap.

Fixes #80136

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 9acc944) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/795000.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/795000.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from 秦龙:

Patch Set 1: Code-Review+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/795000.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runtime: ASAN redzone incorrectly marked as pointers in bitmap

2 participants