encoding/asn1: check Bytes slice length in BitString.At - #81235
Open
TurboRx wants to merge 1 commit into
Open
Conversation
BitString.At documentation states that it returns 0 if the index is out of range. However, it only checks i >= b.BitLength without verifying that i/8 is within len(b.Bytes), causing a runtime panic when BitLength exceeds the slice capacity or when Bytes is nil/empty. Similarly, BitString.RightAlign now safely handles non-positive BitLength values. Fixes golang#81234
Contributor
|
This PR (HEAD: bdf1e2c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/824504. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BitString.At documentation states that it returns 0 if the index is
out of range. However, it only checks i >= b.BitLength without verifying
that i/8 is within len(b.Bytes), causing a runtime panic when BitLength
exceeds the slice capacity or when Bytes is nil/empty.
Similarly, BitString.RightAlign now safely handles non-positive
BitLength values.
Fixes #81234