Skip to content

encoding/asn1: check Bytes slice length in BitString.At - #81235

Open
TurboRx wants to merge 1 commit into
golang:masterfrom
TurboRx:encoding-asn1-bitstring-bounds
Open

encoding/asn1: check Bytes slice length in BitString.At#81235
TurboRx wants to merge 1 commit into
golang:masterfrom
TurboRx:encoding-asn1-bitstring-bounds

Conversation

@TurboRx

@TurboRx TurboRx commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

BitString.At documentation states that it returns 0 if the index is
out of range. However, it only checks i >= b.BitLength without verifying
that i/8 is within len(b.Bytes), causing a runtime panic when BitLength
exceeds the slice capacity or when Bytes is nil/empty.

Similarly, BitString.RightAlign now safely handles non-positive
BitLength values.

Fixes #81234

BitString.At documentation states that it returns 0 if the index is
out of range. However, it only checks i >= b.BitLength without verifying
that i/8 is within len(b.Bytes), causing a runtime panic when BitLength
exceeds the slice capacity or when Bytes is nil/empty.

Similarly, BitString.RightAlign now safely handles non-positive
BitLength values.

Fixes golang#81234
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: bdf1e2c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/824504.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

encoding/asn1: BitString.At panics when Bytes length is less than BitLength

2 participants