Skip to content

cmd/gomobile: add optional -macosversion build flag for macOS#121

Closed
wlynxg wants to merge 1 commit into
golang:masterfrom
wlynxg:master
Closed

cmd/gomobile: add optional -macosversion build flag for macOS#121
wlynxg wants to merge 1 commit into
golang:masterfrom
wlynxg:master

Conversation

@wlynxg

@wlynxg wlynxg commented May 28, 2026

Copy link
Copy Markdown
Contributor

Add a -macosversion build flag for macOS targets and
pass -mmacosx-version-min to clang when the flag is set.

Leave the flag unset by default so existing macOS builds keep their
current deployment target behavior and avoid backward compatibility
regressions.

Apple documents -mmacosx-version-min here:
https://developer.apple.com/library/archive/documentation/Porting/Conceptual/PortingUnix/compiling/compiling.html

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 677f90a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/mobile/+/784400.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Hajime Hoshi:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from wei liu:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Hajime Hoshi:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-05-29T03:00:08Z","revision":"8a635275e408e48c7a43a713b6ec1e6bbdd398b5"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Hajime Hoshi:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_7938>)


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Dmitri Shuralyov:

Patch Set 3: Auto-Submit+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Dmitri Shuralyov:

Patch Set 3: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/784400.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 29, 2026
Add a -macosversion build flag for macOS targets and
pass -mmacosx-version-min to clang when the flag is set.

Leave the flag unset by default so existing macOS builds keep their
current deployment target behavior and avoid backward compatibility
regressions.

Apple documents -mmacosx-version-min here:
https://developer.apple.com/library/archive/documentation/Porting/Conceptual/PortingUnix/compiling/compiling.html

Change-Id: Ifabbb22e5bcec1726df4e45c2f95830966b0d766
GitHub-Last-Rev: 677f90a
GitHub-Pull-Request: #121
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/784400
Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot

Copy link
Copy Markdown
Contributor

This PR is being closed because golang.org/cl/784400 has been merged.

@gopherbot gopherbot closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants