Fix android minsdk usage in binres#99
Conversation
…ld command MinSDK was not properly propagated to binres where AndorinManifest.xml is composed and use-sdk tag is added Change-Id: I3bd34341aee53e02b39edc57967b2338d9beb2b0
…android-minsdk-usage-in-binres Change-Id: I93ae9bd51d91446ca07acf15e5a5e285a5799566
|
This PR (HEAD: ad7f067) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/mobile/+/574615. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574615. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/574615. |
|
Should this also impact internal/binres/binres.go's platformBuildVersionCode Value? |
Change-Id: I711926ac5b9a1b4212ef8e5d6afe18962dbe1c1a
|
@onlysumitg fixed that too |
|
This PR (HEAD: a0bd17f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/mobile/+/574615. Important tips:
|
|
This PR (HEAD: e1251fe) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/mobile/+/574615. Important tips:
|
Fix for an issue golang/go#66011
andtroidapi parameter not working when using gomobile build command