proxy: expand Dialer interface to expose DialContext#164
proxy: expand Dialer interface to expose DialContext#164sjpotter wants to merge 1 commit intogolang:masterfrom
Conversation
currently, the Dialer interface returned (from say proxy.SOCKS5()) only exposes the Dial function, while it has a DialContext function as well. As Dial() usage is deprecated, DialContext should be exposed as well. All implementations in proxy already had a DialContext function besides a single test recording struct, so added a similiar recorder to it.
|
This PR (HEAD: 9178fd7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/465495 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/465495. |
|
Message from Shaya Potter: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/465495. |
|
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/465495. |
currently, the Dialer interface returned (from say proxy.SOCKS5()) only exposes the Dial function, while it has a DialContext function as well. As Dial() usage is deprecated, DialContext should be exposed as well.
All implementations in proxy already had a DialContext function besides a single test recording struct, so added a similiar recorder to it.