-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: improve handling of lost PING in Server #229
Conversation
This is to unify lost ping handling in server and transport.
This PR (HEAD: ef74c95) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/635555. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Message from Hubert Grochowski: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
Message from Damien Neil: Patch Set 3: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
Message from Sean Liao: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-03-09T00:09:21Z","revision":"ecd1f4acf5c5218c45bf4e2c8acab73160a211f2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
Message from Sean Liao: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
Message from Sean Liao: Patch Set 3: Auto-Submit+1 Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/635555. |
This addresses inconsistencies in handling lost PINGs between Server and Transport by: 1. Always logging a message for lost PINGs, regardless of verbose mode. 2. Invoking CountError with the conn_close_lost_ping error key. Fixes golang/go#69963 Change-Id: I58fee489f7896dbb80ccc50265452cd953f7ca6b GitHub-Last-Rev: ef74c95 GitHub-Pull-Request: #229 Reviewed-on: https://go-review.googlesource.com/c/net/+/635555 Auto-Submit: Sean Liao <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Sean Liao <[email protected]> Reviewed-by: Damien Neil <[email protected]> Reviewed-by: David Chase <[email protected]>
This PR is being closed because golang.org/cl/635555 has been merged. |
This addresses inconsistencies in handling lost PINGs
between Server and Transport by:
Fixes golang/go#69963