Add aliases for alt-right, alt-left and alt-delete#7
Open
quackduck wants to merge 2 commits into
Open
Conversation
Contributor
|
This PR (HEAD: 61c0997) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/term/+/383594 to see it. Tip: You can toggle comments from me using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that option+→ (move right by word), option+← (move left by word) and option+delete (delete by word) weren't working, at least on macOS. Used raw mode and some debugging to figure out what escape codes were being signaled.
This PR also removes two unnecessary checks for whether the first byte is the escape character. (Unnecessary because the function returns earlier if the first byte isn't the escape character)
Sample program to see the change this PR makes:
Run this and then compare how alt-right, alt-left and alt-delete work with this change and without.