Skip to content

go/ssa: distinguish goto from continue for range-over-func - #666

Open
cpunion wants to merge 1 commit into
golang:masterfrom
cpunion:rangefunc-goto-label-80860
Open

go/ssa: distinguish goto from continue for range-over-func#666
cpunion wants to merge 1 commit into
golang:masterfrom
cpunion:rangefunc-goto-label-80860

Conversation

@cpunion

@cpunion cpunion commented Aug 13, 2026

Copy link
Copy Markdown

go/ssa currently maps both goto L and continue L to the yield
continuation when L labels a range-over-func statement. A goto L must
instead stop the current iterator call and resume at the parent
function's label so that the range statement restarts.

Keep continue L targeting the yield continuation, but point goto L at
the parent's existing label block. The normal cross-function exit
lowering then records and resumes the jump correctly.

The interpreter regression test distinguishes the two operations by
restarting the same labeled range twice.

Fixes golang/go#80860.

A goto to the label on a range-over-func statement must exit the current yield and resume at the range statement in the parent function. Keep continue targeting the yield continuation, but make goto target the parent label so the existing exit lowering preserves those semantics.

Fixes golang/go#80860.
cpunion added a commit to cpunion/llgo that referenced this pull request Aug 13, 2026
Move the three rangegen correctness failures out of LLGo compatibility xfails while the remaining labeled-goto failure is fixed in x/tools. Keep the upstream runoutput directive and leave resource timeout entries unchanged.

Track golang/go#80860 and golang/tools#666 in each classification reason.
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 468429c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/814460.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/814460.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/814460.
After addressing review feedback, remember to publish your drafts!

cpunion added a commit to cpunion/llgo that referenced this pull request Aug 13, 2026
Move the three rangegen correctness failures out of LLGo compatibility xfails while the remaining labeled-goto failure is fixed in x/tools. Keep the upstream runoutput directive and leave resource timeout entries unchanged.

Track golang/go#80860 and golang/tools#666 in each classification reason.
@gopherbot

Copy link
Copy Markdown
Contributor

Message from Jie Li:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/814460.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/tools/go/ssa: goto to labeled range-over-func is lowered as continue

2 participants