Skip to content

cmd/goyacc: don't panic on grammar files ending without a newline #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaggyinsomniac wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

cmd/goyacc: don't panic on grammar files ending without a newline #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cmd/goyacc/yacc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3156,6 +3156,13 @@ func ungetrune(f *bufio.Reader, c rune) {
if f != finput {
panic("ungetc - not finput")
}
if c == EOF {
// getrune keeps EOF sticky in peekrune, so re-ungetting EOF (e.g.
// from gettok's IDENTIFIER/IDENTCOLON look-ahead at end of file)
// must not trip the single-slot check; an exhausted reader returns
// EOF again anyway.
return
}
if peekrune != 0 {
panic("ungetc - 2nd unget")
}
Expand Down