Skip to content

gopls/internal/vulncheck/scan: pass the pattern after "--" #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yusmer96-maker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gopls/internal/vulncheck/scan: pass the pattern after "--" #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gopls/internal/vulncheck/scan/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ func RunGovulncheck(ctx context.Context, pattern string, snapshot *cache.Snapsho
if db := cache.GetEnv(snapshot, "GOVULNDB"); db != "" {
vulncheckargs = append(vulncheckargs, "-db", db)
}
vulncheckargs = append(vulncheckargs, pattern)
// Pass the pattern after an end-of-options separator, so that it is
// always interpreted as a package pattern.
vulncheckargs = append(vulncheckargs, "--", pattern)
// TODO: support -tags. need to compute tags args from opts.BuildFlags.
// TODO: support -test.

Expand Down