Skip to content

go/callgraph/rta: memoize method lookups in addInvokeEdge #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hungcs wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −3
Open

go/callgraph/rta: memoize method lookups in addInvokeEdge #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions go/callgraph/rta/rta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ type rta struct {

prog *ssa.Program

// methodMemo caches LookupMethod results per (interface method, concrete
// type). addInvokeEdge runs for every (site, type) pair in the invoke
// matrix, and many sites share the same pair; the lookup rebuilds method
// Id strings and searches the method set each time.
methodMemo map[methodMemoKey]*ssa.Function

reflectValueCall *ssa.Function // (*reflect.Value).Call, iff part of prog

worklist []*ssa.Function // list of functions to visit
Expand Down Expand Up @@ -230,11 +236,21 @@ func (r *rta) visitDynCall(site ssa.CallInstruction) {

// ---------- concrete types × invoke sites ----------

type methodMemoKey struct {
imethod *types.Func
C types.Type
}

// addInvokeEdge is called for each new pair (site, C) in the matrix.
func (r *rta) addInvokeEdge(site ssa.CallInstruction, C types.Type) {
// Ascertain the concrete method of C to be called.
imethod := site.Common().Method
cmethod := r.prog.LookupMethod(C, imethod.Pkg(), imethod.Name())
key := methodMemoKey{imethod, C}
cmethod, ok := r.methodMemo[key]
if !ok {
cmethod = r.prog.LookupMethod(C, imethod.Pkg(), imethod.Name())
r.methodMemo[key] = cmethod
}
r.addEdge(site.Parent(), site, cmethod, true)
}

Expand Down Expand Up @@ -314,8 +330,9 @@ func Analyze(roots []*ssa.Function, buildCallGraph bool) *Result {
}

r := &rta{
result: &Result{Reachable: make(map[*ssa.Function]struct{ AddrTaken bool })},
prog: roots[0].Prog,
result: &Result{Reachable: make(map[*ssa.Function]struct{ AddrTaken bool })},
prog: roots[0].Prog,
methodMemo: make(map[methodMemoKey]*ssa.Function),
}

if buildCallGraph {
Expand Down