-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-go: add option to disable tool recompilation prompts #3728
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: bb2b143) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/659815. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
bb2b143
to
b92b631
Compare
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
This PR (HEAD: b92b631) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/659815. Important tips:
|
Message from Hongxiang Jiang: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Ethan Reesor: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-03-21T17:39:22Z","revision":"0e1d73305b93cd73263fa27034d1af43236387d9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from kokoro: Patch Set 2: Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from kokoro: Patch Set 2: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Ethan Reesor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/x_vscode-go-gotip-linux-amd64_docker has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from kokoro: Patch Set 2: kokoro-CI-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Hongxiang Jiang: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Ethan Reesor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Hongxiang Jiang: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from thumphries: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Hongxiang Jiang: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Ethan Reesor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from thumphries: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Message from Ethan Reesor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659815. |
Outdated tool detection relies on
go version -m
, i.e. it does not work in many institutional settings. Shell scripts with alternative tools, shim scripts, or something likedotslash
will all lead to a spurious warning in the IDE to recompile tools.This PR adds a configuration option,
go.toolsManagement.warnOutdated
, that can be set to disable the notification if you know better.Default behaviour should be unchanged.
Updates #3637.