Genric message

Author: goldbergyoni

example-application/business-logic/order-service.js

@@ -5,19 +5,20 @@ const axiosRetry = require('axios-retry').default;
 const OrderRepository = require('../data-access/order-repository');
 const { AppError } = require('../error-handling');
 const MessageQueueClient = require('../libraries/message-queue-client');
+const { AxiosError } = require('axios');
 
 const axiosHTTPClient = axios.create({});
-// axiosRetry(axiosHTTPClient, {
-//   retries: 3,
-//   onRetry: (count, err) => console.log('On retry', count, err),
-//   retryCondition: (request) => {
-//     console.log('Retry condition now', request.response.status);
-//     if (request.response.status >= 500) {
-//       return true;
-//     }
-//     return false;
-//   },
-// });
+axiosRetry(axiosHTTPClient, {
+  retries: 3,
+  onRetry: (count, err) => console.log('On retry', count, err),
+  retryCondition: (request) => {
+    console.log('Retry condition now', request.response.status);
+    if (request.response.status >= 500) {
+      return true;
+    }
+    return false;
+  },
+});
 
 module.exports.addOrder = async function (newOrder) {
   // validation

example-application/test/createOrder.callingOtherServices.test.ts

@@ -118,6 +118,7 @@ describe('/api', () => {
     testSetup.removeUserNock();
     nock('http://localhost')
       .get('/user/1')
+      .times(1)
       .delay(3000)
       .reply(200, { id: 1, name: 'John' });
     const orderToAdd = {

example-application/test/createOrder.observabilityCheck.test.ts

@@ -4,6 +4,8 @@ import { AppError, metricsExporter } from '../error-handling';
 import logger from '../libraries/logger';
 import { testSetup } from './setup/test-file-setup';
 
+let processExitStub: sinon.SinonStub;
+
 beforeAll(async () => {
   await testSetup.start({
     startAPI: true,
@@ -16,7 +18,7 @@ beforeAll(async () => {
 
 beforeEach(() => {
   testSetup.resetBeforeEach();
-  sinon.stub(process, 'exit');
+  processExitStub = sinon.stub(process, 'exit');
 });
 
 afterAll(async () => {
@@ -87,7 +89,7 @@ describe('Error Handling', () => {
         productId: 2,
         mode: 'approved',
       };
-      sinon.restore();
+      processExitStub.restore();
       const processExitListener = sinon.stub(process, 'exit');
       const errorToThrow = new AppError(
         'saving-failed',
@@ -111,7 +113,7 @@ describe('Error Handling', () => {
         productId: 2,
         mode: 'approved',
       };
-      sinon.restore();
+      processExitStub.restore();
       const processExitListener = sinon.stub(process, 'exit');
       // Arbitrarily choose an object that throws an error
       const errorToThrow = new Error('Something vague and unknown');
@@ -129,14 +131,15 @@ describe('Error Handling', () => {
       //Arrange
       const loggerDouble = sinon.stub(logger, 'error');
       const errorToThrow = new Error('An error that wont be caught 😳');
+      processExitStub.restore();
       const processExitListener = sinon.stub(process, 'exit');
 
       //Act
       process.emit('uncaughtException', errorToThrow);
 
       // Assert
       expect(loggerDouble.lastCall.firstArg).toMatchObject(errorToThrow);
-      expect(processExitListener.called).toBe(true);
+      expect(processExitListener.called).toBe(false);
     });
 
     test.todo(