Support generating const and fixed size arrays #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can't do this because const variables cannot refer to statics (inside the macro expansion):
This PR, changes that, so after the macro expansion it looks like a raw byte array. This allows us to create const and static slices as well as fixed size arrays.
Creates a slight change in API, now we are expanding into a raw fixed size array, so to get a slice it requires an extra
&:Before:
After:
I personally think that expanding the use case of this library from just static slices to const and static slices and fixed size arrays is worth this API change. But of course I would like to also hear your opinion.